feat(testing): Always run browser check before BrowserStack tests #2446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lobsterkatie
force-pushed
the
kmclb-always-run-bs-browser-check
branch
from
a97869a
to
baec6cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we have an out-of-date, no-longer-supported browser in our BrowserStack browser list, integration tests are necessarily going to fail, so let's bail earlier rather than later. Tested locally and on Travis and seems to work in both locations:
This also increases the timeout so that the BS tests should hopefully be less brittle.
Oh, and it fixes a typo. :-)
Haven't discussed this with anyone yet, so open to feedback on whether or not this seems like a good idea.