Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add support for parsing hermes-style stack traces #2406

Merged
merged 3 commits into from Feb 4, 2020
Merged

feat: Add support for parsing hermes-style stack traces #2406

merged 3 commits into from Feb 4, 2020

Conversation

Swatinem
Copy link
Member

Before submitting a pull request, please take a look at our
Contributing guidelines and verify:

  • If you've added code that should be tested, please add tests.
  • Ensure your code lints and the test suite passes (yarn lint) & (yarn test).

@Swatinem Swatinem requested a review from HazAT January 31, 2020 10:34
@getsentry-bot
Copy link
Contributor

getsentry-bot commented Jan 31, 2020 •
edited

Warnings
⚠️ Please add a changelog entry for your changes.
Messages
📖 ✅ TSLint passed
📖

@sentry/browser bundle gzip'ed minified size: (ES5: 16.6133 kB) (ES6: 15.6201 kB)

Generated by 🚫 dangerJS against 7b3d017

HazAT
HazAT reviewed Feb 3, 2020
View reviewed changes
Copy link
Member

@HazAT HazAT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait until we implemented the full loop for hermes, if we really need it we will merge it.

@HazAT HazAT merged commit 549947b into master Feb 4, 2020
@HazAT HazAT deleted the hermes-stacktrace branch February 4, 2020 10:42
@HazAT HazAT mentioned this pull request Feb 5, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HazAT HazAT HazAT left review comments

@kamilogorek kamilogorek kamilogorek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Swatinem @getsentry-bot @HazAT @kamilogorek