fix: Dont require transaction to be on the scope to be delivered correctly #2353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamilogorek
force-pushed
the
no-scope-trace-context
branch
from
95b3d2d
to
703c5b4
Compare
kamilogorek
force-pushed
the
no-scope-trace-context
branch
from
703c5b4
to
2e521c2
Compare
|
@kamilogorek any chance to add a test for this? |
|
You got it @dashed |
HazAT
approved these changes
Dec 17, 2019
This was referenced Jan 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, every transaction has to be attached to the scope in order for this block to be called:
sentry-javascript/packages/hub/src/scope.ts
Lines 330 to 333 in ef7b3b2
Sending manually created transaction would end up with:
Error while sending event: SentryError: HTTP Error (400): invalid transaction event: trace context hard-required for transaction events