Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Make sure that XHR is wrapped correctly for TryCatch and Instrument #2343

Merged
merged 1 commit into from
Dec 5, 2019
Merged

fix: Make sure that XHR is wrapped correctly for TryCatch and Instrument #2343

merged 1 commit into from
Dec 5, 2019

Conversation

kamilogorek
Copy link
Contributor

@kamilogorek kamilogorek commented Dec 5, 2019 •
edited

Fixes #2340
Fixes #2337

@getsentry-bot
Copy link
Contributor

Warnings
⚠️ Please add a changelog entry for your changes.
Messages
📖 ✅ TSLint passed
📖

@sentry/browser bundle gzip'ed minified size: (ES5: 16.5547 kB) (ES6: 15.5596 kB)

Generated by 🚫 dangerJS against 33b5e43

HazAT
HazAT approved these changes Dec 5, 2019
View reviewed changes
Copy link
Member

@HazAT HazAT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it with socket.io example and it works

@kamilogorek kamilogorek merged commit 67c726d into master Dec 5, 2019
@kamilogorek kamilogorek deleted the fix-xhr-wrapping branch December 5, 2019 14:46
@vadimka123
Copy link

thanks for update
date of release fix?

@HazAT
Copy link
Member

HazAT commented Dec 5, 2019

@vadimka123 Now :)

@vadimka123
Copy link

you mean new version on npm?

@kamilogorek
Copy link
Contributor Author

@vadimka123 release is in progress as we speak, should be live in ~10-15min

@snyk-bot snyk-bot mentioned this pull request Dec 18, 2019
Merged
@snyk-bot snyk-bot mentioned this pull request Dec 31, 2019
Merged
@snyk-bot snyk-bot mentioned this pull request Jan 12, 2020
Merged
@snyk-bot snyk-bot mentioned this pull request Feb 11, 2020
Merged
@snyk-bot snyk-bot mentioned this pull request Feb 18, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HazAT HazAT HazAT approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@kamilogorek @getsentry-bot @vadimka123 @HazAT