Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/span on headers #2341

Merged
merged 3 commits into from
Dec 5, 2019
Merged

Fix/span on headers #2341

merged 3 commits into from
Dec 5, 2019

Conversation

HazAT
Copy link
Member

@HazAT HazAT commented Dec 5, 2019

This PR fixes a bug where we now send the correct span id in outgoing requests instead of the span id of the parent transaction.

@HazAT HazAT self-assigned this Dec 5, 2019
@getsentry-bot
Copy link
Contributor

getsentry-bot commented Dec 5, 2019 •
edited

Messages
📖 ✅ TSLint passed
📖

@sentry/browser bundle gzip'ed minified size: (ES5: 16.582 kB) (ES6: 15.5801 kB)

Generated by 🚫 dangerJS against 6c36903

kamilogorek
kamilogorek approved these changes Dec 5, 2019
View reviewed changes
Copy link
Contributor

@kamilogorek kamilogorek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

dashed
dashed approved these changes Dec 5, 2019
View reviewed changes
Copy link
Member

@dashed dashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

I was able to infer the descendent transaction from product side.

@dashed
Copy link
Member

dashed commented Dec 5, 2019

@HazAT thanks for looking into this.

@dashed dashed mentioned this pull request Dec 5, 2019
Merged
7 tasks
@kamilogorek kamilogorek merged commit 6025ab9 into master Dec 5, 2019
@kamilogorek kamilogorek deleted the fix/span-on-headers branch December 5, 2019 14:46
@snyk-bot snyk-bot mentioned this pull request Dec 18, 2019
Merged
@snyk-bot snyk-bot mentioned this pull request Dec 31, 2019
Merged
@snyk-bot snyk-bot mentioned this pull request Jan 12, 2020
Merged
@snyk-bot snyk-bot mentioned this pull request Feb 11, 2020
Merged
@snyk-bot snyk-bot mentioned this pull request Feb 18, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dashed dashed dashed approved these changes

@kamilogorek kamilogorek kamilogorek approved these changes

@mitsuhiko mitsuhiko Awaiting requested review from mitsuhiko

Assignees

@HazAT HazAT

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@HazAT @getsentry-bot @dashed @kamilogorek