Require https-proxy-agent only when actually needed

[ouraios]

https-proxy-agent patches core Node methods in https for whatever reason, and that breaks unrelated code. In our app we don't use proxy, and the mere fact that sentry-javascript requires the proxy package, it breaks other code.

See TooTallNate/node-agent-base#35 and sindresorhus/got#951

[HazAT]

Thanks for the PR!
Can you please run yarn lint locally, there are a few linting errors that our CI is not posting here.

[ouraios]

@HazAT I have linting error on @sentry/utils but i haven't edited any filed in @sentry/utils only in @sentry/node :/

[kamilogorek]

@ouraios you need to run yarn build in the root directory in order for TypeScript to pick up files from monorepo correctly

[ouraios]

@kamilogorek Thanks for letting me know, im not used to lerna
But i did the yarn build and i ran yarn lint in both root directory and node package and it's telling me everything is okay :x

[kamilogorek]

Merged by hand 18fbd73
Thanks!

[ouraios]

Thanks a lot for your reactivity !

[kamilogorek]

@ouraios and already released as 5.10.1 if you want to try it out :)

[ouraios]

@kamilogorek Its not released on npm already :(

[HazAT]

@ouraios it is https://www.npmjs.com/package/@sentry/node/v/5.10.1

[jstewmon]

Sorry for commenting on a closed issue. I wanted to leave this on #2085, but GH is having trouble serving that issue page...

agent-base 5.0.0 is out and no longer patches https.request: https://github.com/TooTallNate/node-agent-base/releases/tag/5.0.0

[ouraios]

Great thanks ! it works like a charm !

[kamilogorek]

Awesome! Thanks for a headsup @jstewmon. I'll definitely update that!