Instrumentation refactor #2323
Merged
Instrumentation refactor #2323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rowser sdk itself
HazAT
requested changes
Nov 26, 2019
packages/browser/src/instrument.ts
Outdated
| function instrument(type: InstrumentHandlerType): void { | ||
| if (type === 'console') { | ||
| instrumentConsole(); | ||
| instrumented[type] = true; |
There was a problem hiding this comment.
This probably needs to go outside the if + we need a check each if if already patched.
kamilogorek
force-pushed
the
instrumentation-refactor
branch
from
72a6ed9
to
4dd643c
Compare
kamilogorek
force-pushed
the
instrumentation-refactor
branch
from
4dd643c
to
1721330
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.