Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: Remove process.env.NODE_ENV from Vue integration #2263

Merged
merged 1 commit into from
Oct 10, 2019

Conversation

kamilogorek
Copy link
Contributor

Closes #2250

We can do this because _logErrors already allows for behavior modification and CDN version of Vue doesn't contain this line and which makes it impossible to trigger the log.

@kamilogorek kamilogorek merged commit 68945a1 into master Oct 10, 2019
@kamilogorek kamilogorek deleted the vue-remove-env branch October 10, 2019 09:44
@getsentry-bot
Copy link
Contributor

Warnings
⚠️ Please add a changelog entry for your changes.
Messages
📖 ✅ TSLint passed
📖

@sentry/browser bundle gzip'ed minified size: (ES5: 15.4199 kB) (ES6: 14.6348 kB)

Generated by 🚫 dangerJS against 86955f1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error in Vue Integration with browser script-load
3 participants