Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update node-https-proxy-agent (security fix) #2260

Closed
evanbattaglia opened this issue Oct 8, 2019 · 2 comments · Fixed by #2262
Closed

Update node-https-proxy-agent (security fix) #2260

evanbattaglia opened this issue Oct 8, 2019 · 2 comments · Fixed by #2262

Comments

@evanbattaglia
Copy link

Yesterday a patch and new release for node-https-proxy-agent was released, which fixes a Man-in-the-middle vulnerability:

https://github.com/TooTallNate/node-https-proxy-agent/releases/tag/3.0.0
TooTallNate/proxy-agents#77

The node sentry version relies on version 2.2.1:

https://github.com/getsentry/sentry-javascript/blob/master/packages/node/package.json#L24

Unfortunately this vulnerability is causing a build failure in one of our projects because Snyk complains about the vulnerability:

https://snyk.io/vuln/SNYK-JS-HTTPSPROXYAGENT-469131

It would be great to get sentry using the new version of node-https-proxy-agent so we could just update sentry to fix the build failure.

@evanbattaglia
Copy link
Author

evanbattaglia commented Oct 9, 2019 via email

@kamilogorek
Copy link
Contributor

Anytime. I'll release version 5.7.0 tomorrow morning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants