feat: Extract prototyped data in extractUserData
#2247
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a slightly unusual express server setup in which the client provides their user ID in the
req.user
field, then a middleware replaces this with the corresponding user entry from a database, thus populatingreq.user.email
andreq.user.id
. Unfortunately, it turns out that sentry is unable to extract these fields automatically, because they are defined in the prototype of thereq.user
object, and thus are ignored byhasOwnProperty
. Changing this to a simplein
operator fixes this issue. I don't see a good reason whyhasOwnProperty
should be preferred toin
here, as the extracted fields are configurable anyways.