Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: SessionTiming integration #2150

Merged
merged 1 commit into from
Jul 5, 2019
Merged

feat: SessionTiming integration #2150

merged 1 commit into from
Jul 5, 2019

Conversation

kamilogorek
Copy link
Contributor

@kamilogorek kamilogorek commented Jul 3, 2019

Fixes: #1823

Usage:

import { SessionTiming } from '@sentry/integration';

Sentry.init({
  integrations: [new SessionTiming()]
});

@kamilogorek kamilogorek requested a review from HazAT July 3, 2019 14:30
@kamilogorek kamilogorek changed the title feat: SessionDuration integration feat: SessionTiming integration Jul 3, 2019
@getsentry-bot
Copy link
Contributor

getsentry-bot commented Jul 3, 2019

Fails
🚫

TSLint failed: @sentry/browser

  • ERROR: /home/travis/build/getsentry/sentry-javascript/packages/browser/src/integrations/trycatch.ts[73, 22]: Avoid referencing unbound methods which may cause unintentional scoping of 'this'.
  • ERROR: /home/travis/build/getsentry/sentry-javascript/packages/browser/src/integrations/trycatch.ts[73, 15]: Expression is always true.
Warnings
⚠️ Please add a changelog entry for your changes.
Messages
📖

@sentry/browser bundle gzip'ed minified size: (ES5: 15.916 kB) (ES6: 15.1221 kB)

Generated by 🚫 dangerJS against e6bd3b9

Copy link
Member

@HazAT HazAT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid integration 👍

The lint issues are unrelated to this PR but still here.

Also, Changelog. Otherwise 💯

@kamilogorek kamilogorek merged commit 0b1c050 into master Jul 5, 2019
@kamilogorek kamilogorek deleted the session-timing branch July 5, 2019 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

session:duration gone in @sentry/browser (vs raven-js)
3 participants