Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Provide optional shouldHandleError option for node errorHandler #2146

Merged
merged 2 commits into from
Jul 5, 2019
Merged

feat: Provide optional shouldHandleError option for node errorHandler #2146

merged 2 commits into from
Jul 5, 2019

Conversation

kamilogorek
Copy link
Contributor

@kamilogorek kamilogorek commented Jul 2, 2019 •
edited

@kamilogorek kamilogorek requested a review from HazAT July 2, 2019 15:47
This was referenced Jul 2, 2019
Merged
Closed
@getsentry-bot
Copy link
Contributor

getsentry-bot commented Jul 2, 2019 •
edited

Warnings
⚠️ Please add a changelog entry for your changes.
Messages
📖 ✅ TSLint passed
📖

@sentry/browser bundle gzip'ed minified size: (ES5: 15.917 kB) (ES6: 15.1221 kB)

Generated by 🚫 dangerJS against 874610f

HazAT
HazAT approved these changes Jul 5, 2019
View reviewed changes
Copy link
Member

@HazAT HazAT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Changelog

packages/node/src/handlers.ts Outdated Show resolved Hide resolved
@kamilogorek @HazAT
Update packages/node/src/handlers.ts
874610f 
Co-Authored-By: Daniel Griesser <daniel.griesser.86@gmail.com>
@kamilogorek kamilogorek merged commit a952720 into master Jul 5, 2019
@kamilogorek kamilogorek deleted the configurable-node-handler branch July 5, 2019 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HazAT HazAT HazAT approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Undocumented errorHandler behavior results in unreported 500s
3 participants
@kamilogorek @getsentry-bot @HazAT