Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support sentry-webpack-plugin release injection in browser and node SDKs #2132

Merged

Conversation

tstirrat15
Copy link
Contributor

@tstirrat15 tstirrat15 commented Jun 24, 2019

Fixes #2107
Fixes getsentry/sentry-webpack-plugin#126

Motivation

See #2107 and this comment on the sentry-webpack-plugin issue.

sentry-webpack-plugin adds the following to the global scope (whether backend or frontend):

{ SENTRY_RELEASE: { id: 'your-id-string' } }

It's picked up automatically by raven-js (though, interestingly, not by raven-node).

This work adds the same functionality to the new browser and node SDKs.

Changes

  • Add clarification to the CONTRIBUTING.md file that you have to run yarn build before you can run tests against any of the packages
  • Add tests that capture the desired behavior
  • Add references to the global SENTRY_RELEASE variable if it's available

Copy link
Member

@HazAT HazAT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 💯

@HazAT
Copy link
Member

HazAT commented Jun 27, 2019

Fixes #2107

@HazAT HazAT merged commit a44dcb8 into getsentry:master Jun 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants