Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(utils): add polyfill for Object.setPrototypeOf (#2124) #2127

Merged
merged 2 commits into from
Jun 27, 2019
Merged

fix(utils): add polyfill for Object.setPrototypeOf (#2124) #2127

merged 2 commits into from
Jun 27, 2019

Conversation

lext-7
Copy link
Contributor

@lext-7 lext-7 commented Jun 21, 2019

Fix a problem described in #2124

  • If you've added code that should be tested, please add tests.
  • Ensure your code lints and the test suite passes (yarn lint) & (yarn test).

@lext-7 lext-7 requested a review from kamilogorek as a code owner June 21, 2019 05:33
HazAT
HazAT requested changes Jun 21, 2019
View reviewed changes
Copy link
Member

@HazAT HazAT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work on this but we will not merge this since it adds another dependency that is only needed in an 8 year old version of Android.
Please consider adding the code directly into the function instead of adding a dependency.

@lext-7 lext-7 closed this Jun 22, 2019
@lext-7 lext-7 force-pushed the bugfix-setprototypeof-polyfill branch from a9ef7f8 to b03851e Compare June 22, 2019 12:01
@lext-7
Copy link
Contributor Author

lext-7 commented Jun 22, 2019

Sorry for closing it with a mistake.

@lext-7 lext-7 reopened this Jun 22, 2019
@lext-7
Copy link
Contributor Author

lext-7 commented Jun 27, 2019

Can it be merged ?

HazAT
HazAT approved these changes Jun 27, 2019
View reviewed changes
Copy link
Member

@HazAT HazAT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx!

@HazAT HazAT merged commit 5bfb758 into getsentry:master Jun 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HazAT HazAT HazAT approved these changes

@kamilogorek kamilogorek Awaiting requested review from kamilogorek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lext-7 @HazAT