Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove unsafe ‘any' from NodeOptions type #2111

Merged

Conversation

chrisblossom
Copy link
Contributor

Currently NodeOptions are not typed because [key: string]: any matches any key.

FYI, I was unable to get lerna (yes I am familiar how it works and followed Contributing as well) to properly install so I am unable to check if typescript still passes.

Before submitting a pull request, please take a look at our
Contributing guidelines and verify:

  • If you've added code that should be tested, please add tests.
  • Ensure your code lints and the test suite passes (yarn lint) & (yarn test).

@kamilogorek kamilogorek merged commit 1127cf4 into getsentry:master Jul 5, 2019
@kamilogorek
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants