Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

domain.enter is not a function #1843

Closed
4 of 8 tasks
adriaanmeuris opened this issue Jan 18, 2019 · 9 comments
Closed
4 of 8 tasks

domain.enter is not a function #1843

adriaanmeuris opened this issue Jan 18, 2019 · 9 comments

Comments

@adriaanmeuris
Copy link

Package + Version

  • @sentry/browser
  • @sentry/node
  • raven-js
  • raven-node (raven for node)
  • other:

Version:

4.5.2

Description

We're facing issues since 4.5.2, reverting back to 4.5.1 solves the issue. We don't know exactly what is going on, but tried to gather as much information as possible:

  • An endpoint to our Express app report some messages to our Sentry account

  • With 4.5.2, our error middleware catches an error and tries to output it is to the user, which results in a Can't set headers after they are sent. error. It's stack refers to @sentry/node/dist/handlers.js:180:9:
    Stack

  • When logging this error to the console, it refers to a TypeError: TypeError: domain.enter is not a function:
    Domain error

  • We're also seeing a very strange AssertionError, without any more details about the exceptions (there's no stack):
    AssertionError

  • Reverting to 4.5.1 resolves all these issues

Any help would be greatly appreciated.

@neemah
Copy link

neemah commented Jan 21, 2019

After upgrade to 4.5.2 we started to receive similar strange errors, and had to rollback.

@rodneyrehm
Copy link

Same problem here in @sentry/node in version 4.5.3 on node v10.11.0. Downgrade to v4.5.1 solves the problem for me as well.

TypeError: domain.enter is not a function
    at ServerResponse.EventEmitter.emit (domain.js:459:10)
    at Socket.onServerResponseClose (_http_server.js:169:44)
    at Socket.emit (events.js:187:15)
    at Socket.EventEmitter.emit (domain.js:442:20)
    at TCP._handle.close (net.js:606:12)
TypeError: app.render is not a function
    at ServerResponse.render (…/server/node_modules/express/lib/response.js:1008:7)
    at handleError (…/server/src/errors.js:46:7)
    at Layer.handle_error (…/server/node_modules/express/lib/router/layer.js:71:5)
    at trim_prefix (…/server/node_modules/express/lib/router/index.js:315:13)
    at …/server/node_modules/express/lib/router/index.js:284:7
    at Function.process_params (…/server/node_modules/express/lib/router/index.js:335:12)
    at next (…/server/node_modules/express/lib/router/index.js:275:10)
    at sentryErrorMiddleware (…/server/node_modules/@sentry/node/dist/handlers.js:180:9)
    at Layer.handle_error (…/server/node_modules/express/lib/router/layer.js:71:5)
    at trim_prefix (…/server/node_modules/express/lib/router/index.js:315:13)

@vvo
Copy link

vvo commented Feb 7, 2019

We're also seeing "app.render is not a function" which is a very odd error that we do not understand

@kamilogorek
Copy link
Contributor

Fixed in 4.5.4https://github.com/getsentry/sentry-javascript/releases/tag/4.5.4
Sorry for the inconvenience :)

@vvo
Copy link

vvo commented Feb 25, 2019

Hey @kamilogorek just for my own curiosity, which commit in particular fixed our issue?

@kamilogorek
Copy link
Contributor

@adriaanmeuris @vvo could you please give a 4.6.4 a try and let us know if everything is fixed for you?

@kamilogorek
Copy link
Contributor

@vvo we fixed prototype inheritance, but missed one bit. Should be fixed in 4.6.4

@adriaanmeuris
Copy link
Author

@kamilogorek sorry for the delay, but due to the many releases and bugs we've taken extra time to test before releasing on production. For now, all is good and we don't see errors as described in this issue.

we do see a sporadic cpu/memory spikes but that seems to be related to #1395 - will follow up there.

@MarcMcIntosh
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants