Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(node): Add missing vercelAIIntegration export #15318

Merged
merged 7 commits into from
Feb 7, 2025

Conversation

aryanvdesh
Copy link
Contributor

@aryanvdesh aryanvdesh commented Feb 6, 2025

(description updated by @Lms24 for posterity)

This PR exports the previously missing vercelAIIntegration. It's enabled by default but prior to this chance, it couldn't be manually added due to it not being exported by the Node SDK.

@Lms24 Lms24 changed the title fix: add missing integration (vercel ai) fix: Add missing integration (vercel ai) Feb 6, 2025
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @aryanvdesh thanks for opening this PR! We'll merge this in soon, just waiting on CI to pass

@Lms24 Lms24 changed the title fix: Add missing integration (vercel ai) fix(node): Add missing integration (vercel ai) export Feb 6, 2025
@Lms24 Lms24 self-assigned this Feb 6, 2025
@mydea
Copy link
Member

mydea commented Feb 6, 2025

the node-exports-test-app E2E test is failing, because this needs to be re-exported in some places: https://github.com/getsentry/sentry-javascript/actions/runs/13170232805/job/36778885557?pr=15318

  • astro
  • bun
  • aws-serverless
  • google-cloud-serverless

if you could add a re-export there, then tests should pass!

@Lms24 Lms24 changed the title fix(node): Add missing integration (vercel ai) export feat(node): Add missing integration (vercel ai) export Feb 6, 2025
aryanvdesh and others added 2 commits February 6, 2025 07:08

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@aryanvdesh
Copy link
Contributor Author

@Lms24 @mydea just added the missing imports!

@aryanvdesh aryanvdesh requested a review from Lms24 February 6, 2025 15:17
@Lms24 Lms24 changed the title feat(node): Add missing integration (vercel ai) export feat(node): Add missing vercelAIIntegration export Feb 6, 2025
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@aryanvdesh aryanvdesh requested a review from Lms24 February 7, 2025 15:11
@Lms24 Lms24 merged commit 725a548 into getsentry:develop Feb 7, 2025
85 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants