feat(core)!: Pass root spans to beforeSendSpan and disallow returning null
#14831
+365
−57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
Lms24
reviewed
Jan 2, 2025
Lms24
approved these changes
Jan 7, 2025
packages/core/src/baseclient.ts
Outdated
| ...event.sdkProcessingMetadata, | ||
| spanCountBeforeProcessing: spanCountBefore, | ||
| }; | ||
| } | ||
| return beforeSendTransaction(event, hint); | ||
| return beforeSendTransaction(processedEvent as TransactionEvent, hint); |
There was a problem hiding this comment.
l (not blocking): Is there a way we can get rid of this type cast? No worries if not, just curious since there's the isTransactionEvent check above 🤔
There was a problem hiding this comment.
yeah somehow no matter what I do, after the merge call ts thinks it's an event again, even if I do
processedEvent = merge<TransactionEvent>(
processedEvent,
convertSpanJsonToTransactionEvent(processedRootSpanJson),
);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
beforeSendSpanbeforeSendSpanLooked at two options for passing the root span:
SentrySpanclass, before converting the root span into a transaction.SpanJSONout of an event and then writing back the updated values into the event.Went with (2), passing the root span within
processBeforeSendto have all processing hooks centrally in one place and because the other approach would have been too messy.closes #14336