New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
React Router V5 Integration is not parameterizing transaction names #11815
Comments
We have since bumped to beta 4 of V8. |
Hey, just to clarify: Are you using without this, you wouldn't get parametrized routes. |
Yes sorry, i forgot to include that portion of our Sentry file: https://github.com/codecov/gazebo/blob/main/src/sentry.ts#L53 |
Thanks for bearing with us! I identified the problem and have a fix up here: #11855 |
@mydea thanks for the quick fix, wondering if this will also be included with V8? |
Yes, it will be in the next release - most likely we'll cut v8.0.0-beta.6 early thursday! |
Awesome tysm! |
Turns out we were not correctly setting parametrized route names for react router v4/v5 😬 We had no proper test covering this. So I added a new E2E test `react-router-5` that actually checks that parametrization etc. works as expected. While at it, I also updated the react-router-6 E2E test to actually check these things as well - previously, we mostly only checked that _anything_ was sent to sentry, but didn't look at the content we sent. Fixes #11815
Is there an existing issue for this?
How do you use Sentry?
Sentry Saas (sentry.io)
Which SDK are you using?
@sentry/react
SDK Version
8.0.0-beta.3
Framework Version
React 18.2.0
Link to Sentry event
https://codecov.sentry.io/performance/?project=5514400&statsPeriod=14d
SDK Setup
Steps to Reproduce
v8.0.0-beta.3
Just to note, we do currently have two routes that are not wrapped with the Sentry helper.
Expected Result
Actual Result
The text was updated successfully, but these errors were encountered: