New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically instrument profiling for Node and Python when Sentry is set up via the Lambda Layer #11800
Comments
Assigning to @getsentry/support for routing ⏲️ |
Routing to @getsentry/product-owners-profiling for triage ⏲️ |
@AbhiPrasad I guess this would mean that we inject the profiling integration based on an env variable. Is this something that we do in any other SDK and would there be a reason not to do this? |
This is a little more complicated because this means we would have to bundle in I think the environmental variable is a great idea, but the bundling will cause us complexities, especially because there are 0 tests. I'm going to transfer this to the Sentry JavaScript SDK repo, but backlog because we have higher priority items atm. Maybe after v8 releases we can revisit. |
Oh yes, I was assuming the user would have to ensure the binaries are there, so some manual work would be required anyways. Bundling the binaries with the package isnt a good idea imo, I'd rather defer to manual instrumentation |
Problem Statement
Currently the Lambda Layer setup instructions for serverless functions suggest that errors and performance is automatically enabled:
(I assume this applies to both Node and Python. The Node lambda layer docs are not explicit about what you get out of the box)
Beyond the above, though, it seems profiling has to be manually set up for Node lambdas and I believe also for Python lambdas. This manual step can be difficult when a customer has, say 1000 lambdas and doesn't want to instrument them all with profiling individually.
Solution Brainstorm
Add a configuration option for Node and Python profiling in the lambda layer.
Product Area
Profiling
The text was updated successfully, but these errors were encountered: