Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(spotlight): Use unpatched http.request #10369

Merged
merged 1 commit into from Jan 26, 2024
Merged

Conversation

mydea
Copy link
Member

@mydea mydea commented Jan 26, 2024

To avoid capturing our own requests.

See getsentry/spotlight#335

To avoid capturing our own requests.
@mydea mydea requested review from HazAT and Lms24 January 26, 2024 15:59
@mydea mydea self-assigned this Jan 26, 2024
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 77.89 KB (+0.02% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 69.08 KB (+0.03% 🔺)
@sentry/browser (incl. Tracing, Replay with Canvas) - Webpack (gzipped) 72.97 KB (+0.03% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 62.72 KB (+0.02% 🔺)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 33.12 KB (+0.05% 🔺)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 31.28 KB (0%)
@sentry/browser (incl. sendFeedback) - Webpack (gzipped) 31.29 KB (0%)
@sentry/browser - Webpack (gzipped) 22.54 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 75.71 KB (+0.14% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 67.26 KB (+0.16% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 33.11 KB (+0.32% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped) 24.47 KB (+0.03% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 211.89 KB (+0.2% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 99.91 KB (+0.43% 🔺)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 73.23 KB (+0.08% 🔺)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 36.2 KB (+0.25% 🔺)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 69.49 KB (+0.02% 🔺)
@sentry/react - Webpack (gzipped) 22.58 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 86.19 KB (+0.05% 🔺)
@sentry/nextjs Client - Webpack (gzipped) 50.49 KB (+0.1% 🔺)
@sentry-internal/feedback - Webpack (gzipped) 17.21 KB (0%)
@sentry/browser (incl. browserTracingIntegration) - Webpack (gzipped) 33.02 KB (added)

@mydea mydea requested a review from AbhiPrasad January 26, 2024 16:07
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@mydea mydea merged commit dd77951 into develop Jan 26, 2024
73 checks passed
@mydea mydea deleted the fn/spotlight-unpatched-http branch January 26, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants