Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sveltekit): Update default integration handling & deprecate addOrUpdateIntegration #10263

Merged
merged 3 commits into from Jan 23, 2024
Merged

feat(sveltekit): Update default integration handling & deprecate addOrUpdateIntegration #10263

merged 3 commits into from Jan 23, 2024

Conversation

mydea
Copy link
Member

@mydea mydea commented Jan 19, 2024

This updates the last usage of addOrUpdateIntegration and deprecates it.

@mydea mydea requested review from lforst and Lms24 January 19, 2024 12:00
@mydea mydea self-assigned this Jan 19, 2024
@mydea mydea force-pushed the fn/sveltekit-custom-default-integrations branch 2 times, most recently from fbdd611 to 2151c82 Compare January 19, 2024 12:41
Lms24
Lms24 approved these changes Jan 19, 2024
View reviewed changes
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

@mydea mydea force-pushed the fn/sveltekit-custom-default-integrations branch from 2151c82 to 6278baa Compare January 19, 2024 14:24
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 19, 2024 •
edited

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 77.69 KB (0%)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 68.95 KB (0%)
@sentry/browser (incl. Tracing, Replay with Canvas) - Webpack (gzipped) 72.84 KB (0%)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 62.58 KB (0%)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 32.96 KB (0%)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 31.18 KB (0%)
@sentry/browser (incl. sendFeedback) - Webpack (gzipped) 31.19 KB (0%)
@sentry/browser - Webpack (gzipped) 22.53 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 75.33 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 66.97 KB (0%)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 32.8 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped) 24.32 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 210.96 KB (0%)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 98.94 KB (0%)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 72.76 KB (0%)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 35.9 KB (0%)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 69.35 KB (0%)
@sentry/react - Webpack (gzipped) 22.58 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 85.97 KB (0%)
@sentry/nextjs Client - Webpack (gzipped) 50.25 KB (0%)
@sentry-internal/feedback - Webpack (gzipped) 17.14 KB (0%)

@mydea mydea force-pushed the fn/sveltekit-custom-default-integrations branch from 6278baa to af0a19f Compare January 23, 2024 13:51
@mydea mydea merged commit 62b0c4d into develop Jan 23, 2024
92 checks passed
@mydea mydea deleted the fn/sveltekit-custom-default-integrations branch January 23, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lms24 Lms24 Lms24 approved these changes

@lforst lforst Awaiting requested review from lforst

Assignees

@mydea mydea

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mydea @Lms24