Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tracing): Gate mongo operation span data behind sendDefaultPii #10227

Merged
merged 3 commits into from Jan 18, 2024

Conversation

AbhiPrasad
Copy link
Member

As was raised in #10219, we set some extra operation based fields on span data for mongodb.

This is unfortunately just serialized output, which means it can contain PII (it needs to be paramaterized for PII to be removed).

Given this data will change a lot when we switch to OTEL, gate setting this specific span data behind sendDefaultPii.

Copy link
Contributor

github-actions bot commented Jan 17, 2024

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 77.52 KB (0%)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 68.8 KB (0%)
@sentry/browser (incl. Tracing, Replay with Canvas) - Webpack (gzipped) 72.68 KB (0%)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 62.43 KB (0%)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 32.8 KB (0%)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 31.13 KB (0%)
@sentry/browser - Webpack (gzipped) 22.48 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 75.11 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 66.72 KB (0%)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 32.58 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped) 24.19 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 210.25 KB (0%)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 98.22 KB (0%)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 72.34 KB (0%)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 35.62 KB (0%)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 69.2 KB (0%)
@sentry/react - Webpack (gzipped) 22.52 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 85.79 KB (0%)
@sentry/nextjs Client - Webpack (gzipped) 49.93 KB (0%)
@sentry-internal/feedback - Webpack (gzipped) 17.12 KB (0%)

@AbhiPrasad AbhiPrasad enabled auto-merge (squash) January 18, 2024 18:48
@AbhiPrasad AbhiPrasad merged commit 97c4e3b into develop Jan 18, 2024
94 checks passed
@AbhiPrasad AbhiPrasad deleted the abhi-mongodb-pii branch January 18, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants