-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate Remaining Span
class and interface fields
#10184
Comments
The rest looks good to me 👍 |
setting them via
|
yeah, retroactive update of start/end time is not possible. This needs to be rewritten to buffer the endtime somewhere (?) and set it - but I think I did this here already kind of #9972, so should work, I hope..! |
I will deprecate the timestamps! |
Clarify the API status of the `Span.getSpanJSON` method. This method is purely purposed for internal usage and users should not rely on it but instead on `spanToJSON`. ref #10184
This PR deprecates the `status` field on the span interface as well as on the class. The replacements for this field are * `span.setStatus` to set or update a span status (this API exists on the Otel Span interface but the types don't align yet) * `spanToJson` to read the status ref #10184
I realized we still have a lot of fields on the
Span
class and interface that need to be deprecated.Span
InterfacestartTimestamp
&endTimestamp
#10192Span.status
#10208Span.isSuccess()
in favor of reading span status #10213Span.parentSpanId
#10244op
onSpan
interface #10217Span.origin
in favor ofsentry.origin
attribute #10260Span.setHttpStatus
in favor ofsetHttpStatus
#10268Additional public
Span
class fieldsSpan.getSpanJSON
method as internal #10197Span.spanRecorder
#10199Span.op
in favor of op attribute #10189ref #10033
Related fields on other interfaces
StartSpanOptions.origin
in favour of passing attribute #10274spanStatusfromHttpCode
in favour ofgetSpanStatusFromHttpCode
#10361The text was updated successfully, but these errors were encountered: