Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): Write data from setUser, setTags, setExtras, setTag, setExtra, and setContext to isolation scope #10163

Merged
merged 10 commits into from Jan 15, 2024

Conversation

lforst
Copy link
Member

@lforst lforst commented Jan 12, 2024

In the new scope model, all the global Sentry.setX() APIs should write to the isolation scope. This PR introduces that in the hub as a compatibility and migration layer until we deprecate the hub in v8.

One exception to this rule is the addBreadcrumb function, which I opted not to let write to the isolation scope to avoid duplicate breadcrumbs. We can still write breadcrumbs to the isolation scope ourselves by calling .addBreadcrumb() on the isolation scope directly. This should therefore be non-blocking to anybody.

Copy link
Contributor

github-actions bot commented Jan 12, 2024

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 77.11 KB (+0.12% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 68.47 KB (+0.13% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 62.13 KB (+0.15% 🔺)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 32.5 KB (+0.29% 🔺)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 31.09 KB (+0.28% 🔺)
@sentry/browser - Webpack (gzipped) 22.44 KB (+0.43% 🔺)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 74.79 KB (+0.13% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 66.44 KB (+0.13% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 32.27 KB (+0.28% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped) 24.09 KB (+0.47% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 209.43 KB (+0.2% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 97.49 KB (+0.42% 🔺)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 72.08 KB (+0.57% 🔺)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 35.29 KB (+0.28% 🔺)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 68.85 KB (+0.13% 🔺)
@sentry/react - Webpack (gzipped) 22.48 KB (+0.43% 🔺)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 85.54 KB (+0.13% 🔺)
@sentry/nextjs Client - Webpack (gzipped) 49.65 KB (+0.23% 🔺)
@sentry-internal/feedback - Webpack (gzipped) 17.11 KB (+0.64% 🔺)

@lforst lforst marked this pull request as ready for review January 15, 2024 12:40
@lforst lforst merged commit b174d53 into develop Jan 15, 2024
96 checks passed
@lforst lforst deleted the lforst-write-to-isolation-scope branch January 15, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants