New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): Write data from setUser
, setTags
, setExtras
, setTag
, setExtra
, and setContext
to isolation scope
#10163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g`, `setExtra`, and `setContext` to isolation scope
size-limit report 📦
|
mydea
reviewed
Jan 15, 2024
Co-authored-by: Francesco Novy <francesco.novy@sentry.io>
mydea
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the new scope model, all the global
Sentry.setX()
APIs should write to the isolation scope. This PR introduces that in the hub as a compatibility and migration layer until we deprecate the hub in v8.One exception to this rule is the
addBreadcrumb
function, which I opted not to let write to the isolation scope to avoid duplicate breadcrumbs. We can still write breadcrumbs to the isolation scope ourselves by calling.addBreadcrumb()
on the isolation scope directly. This should therefore be non-blocking to anybody.