Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): Deprecate span.startChild() #10091

Merged
merged 1 commit into from Jan 8, 2024
Merged

Conversation

mydea
Copy link
Member

@mydea mydea commented Jan 8, 2024

We still have quite a lot of these ourselves, but we can refactor them over time during the v8 preparation.

But with this, I think we have the most important deprecations mostly done!

@mydea mydea self-assigned this Jan 8, 2024
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! So to confirm, the intended replacement strategy is to no longer start a child for a specific span but use startSpan and therefore start a child for whatever span is currently active on the scope?

@mydea
Copy link
Member Author

mydea commented Jan 8, 2024

LGTM! So to confirm, the intended replacement strategy is to no longer start a child for a specific span but use startSpan and therefore start a child for whatever span is currently active on the scope?

Yes! We need to go through all our usage. We also need to deprecate getActiveTransaction() which we use a lot there. This should just be auto-handled by startSpan()!

We still have quite a lot of these ourselves, but we can refactor them over time during the v8 preparation.
@mydea mydea force-pushed the fn/deprecate-spanStartChild branch from c40c4bd to c7d7c64 Compare January 8, 2024 09:14
@mydea mydea merged commit 548d455 into develop Jan 8, 2024
95 checks passed
@mydea mydea deleted the fn/deprecate-spanStartChild branch January 8, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants