Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(node): Update and vendor https-proxy-agent #10088

Merged
merged 7 commits into from Jan 18, 2024

Conversation

timfish
Copy link
Collaborator

@timfish timfish commented Jan 7, 2024

Closes #9199

This PR vendors the https-proxy-agent code and in the process updates to v7.0.0.

https-proxy-agent is our last remaining cjs-only dependency so this is required for #10046.

This removes the following dependencies:

  • https-proxy-agent@5.0.1
  • agent-base@6.0.2
  • debug@4.3.4
  • ms@2.1.2

The vendored code has been modified to use the Sentry logger rather than debug.

Initially, rather than modify the vendored code substantially just to pass our tight lint rules, I've disabled a few of the less important lints that would make it particularly tricky to pull in upstream bug fixes:

/* eslint-disable @typescript-eslint/explicit-member-accessibility */
/* eslint-disable @typescript-eslint/member-ordering */
/* eslint-disable jsdoc/require-jsdoc */

Min supported Node version

https-proxy-agent has a @types/node@14.18.45 dev dependency but apart from adding an import for URL, I can't find anything that would stop it working on older versions of node and there is nothing in the changelogs that would suggest the min supported version has changed.

@timfish
Copy link
Collaborator Author

timfish commented Jan 12, 2024

Once #10156 is merged, we can test this!

@timfish timfish marked this pull request as ready for review January 17, 2024 12:06
@timfish
Copy link
Collaborator Author

timfish commented Jan 17, 2024

This is now tested via a previously added integration test!

Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@AbhiPrasad
Copy link
Member

Going to update this branch so we can get it out with the next release

@AbhiPrasad AbhiPrasad enabled auto-merge (squash) January 18, 2024 19:26
@AbhiPrasad AbhiPrasad merged commit acf58d3 into getsentry:develop Jan 18, 2024
53 checks passed
@timfish timfish deleted the feat/vendor-http-proxy-agent branch January 19, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Node SDK - Vendor dependencies
2 participants