feat(core): Add spanToJSON() method to get span properties
#10074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 馃摝
|
lforst
approved these changes
Jan 5, 2024
Comment on lines
+59
to
+65
| "madge": { | ||
| "detectiveOptions": { | ||
| "ts": { | ||
| "skipTypeImports": true | ||
| } | ||
| } | ||
| }, |
There was a problem hiding this comment.
Circ deps (even types) are usually very smelly. Is this 100% necessary?
There was a problem hiding this comment.
yes, it is - as we need the util in spanUtils, and we need spanUtils in span, and for the util we need the span class from span 馃槵 at least I couldn't think of a way to make this work properly :( we can remove it in v8 though, then we don't need to import from spanUtils in span anymore!
There was a problem hiding this comment.
Alright then! Let's add a comment/todo somewhere then to remove this opt-out again (if you also think that it's worth keeping in general in the future).
There was a problem hiding this comment.
(or open for other ideas, of course)
Lms24
approved these changes
Jan 5, 2024
mydea
commented
Jan 5, 2024
| * Convert a span to a JSON representation. | ||
| * Note that all fields returned here are optional and need to be guarded against. | ||
| * | ||
| * Note: Because of this, we currently have a circular type dependency (which we opted out of in package.json). |
There was a problem hiding this comment.
@lforst added this comment here for the future!
This is supposed to be an internal API and not necessarily to be used by users. add comment for circular dependency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is supposed to be an internal API and not necessarily to be used by users.
Naming wise, it's a bit tricky... I went with
JSONto make it very clear what this is for, but 馃し