From ff24d8e926f85f545d6fc48a465245e7d868a4a1 Mon Sep 17 00:00:00 2001 From: Naseem <24660299+naseemkullah@users.noreply.github.com> Date: Sat, 18 Sep 2021 15:36:31 -0400 Subject: [PATCH] dedupe HEARTBEAT_INTERVAL between src and test --- packages/tracing/src/idletransaction.ts | 3 ++- packages/tracing/test/idletransaction.test.ts | 8 ++++++-- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/packages/tracing/src/idletransaction.ts b/packages/tracing/src/idletransaction.ts index eb71680e0732..a43a91b27238 100644 --- a/packages/tracing/src/idletransaction.ts +++ b/packages/tracing/src/idletransaction.ts @@ -7,6 +7,7 @@ import { SpanStatus } from './spanstatus'; import { Transaction } from './transaction'; export const DEFAULT_IDLE_TIMEOUT = 1000; +export const HEARTBEAT_INTERVAL = 5000; /** * @inheritDoc @@ -266,7 +267,7 @@ export class IdleTransaction extends Transaction { logger.log(`pinging Heartbeat -> current counter: ${this._heartbeatCounter}`); setTimeout(() => { this._beat(); - }, 5000); + }, HEARTBEAT_INTERVAL); } } diff --git a/packages/tracing/test/idletransaction.test.ts b/packages/tracing/test/idletransaction.test.ts index d9a4f4cbe791..f8ece5a0578d 100644 --- a/packages/tracing/test/idletransaction.test.ts +++ b/packages/tracing/test/idletransaction.test.ts @@ -1,7 +1,12 @@ import { BrowserClient } from '@sentry/browser'; import { Hub } from '@sentry/hub'; -import { DEFAULT_IDLE_TIMEOUT, IdleTransaction, IdleTransactionSpanRecorder } from '../src/idletransaction'; +import { + DEFAULT_IDLE_TIMEOUT, + HEARTBEAT_INTERVAL, + IdleTransaction, + IdleTransactionSpanRecorder, +} from '../src/idletransaction'; import { Span } from '../src/span'; import { SpanStatus } from '../src/spanstatus'; @@ -177,7 +182,6 @@ describe('IdleTransaction', () => { describe('heartbeat', () => { it('does not mark transaction as `DeadlineExceeded` if idle timeout has not been reached', () => { - const HEARTBEAT_INTERVAL = 5000; // 20s to exceed 3 heartbeats const transaction = new IdleTransaction({ name: 'foo' }, hub, 20000); const mockFinish = jest.spyOn(transaction, 'finish');