From 8f593f9d5ad52227e7f7464a69e3bbef9f44fbc8 Mon Sep 17 00:00:00 2001 From: Francesco Novy Date: Thu, 3 Nov 2022 14:08:57 +0100 Subject: [PATCH] chore(otel): Move `Instrumenter` type to `@sentry/types` --- packages/node/src/types.ts | 6 ++---- packages/types/src/index.ts | 1 + packages/types/src/instrumenter.ts | 1 + 3 files changed, 4 insertions(+), 4 deletions(-) create mode 100644 packages/types/src/instrumenter.ts diff --git a/packages/node/src/types.ts b/packages/node/src/types.ts index 2ec8b93c0408..c78741e39230 100644 --- a/packages/node/src/types.ts +++ b/packages/node/src/types.ts @@ -1,9 +1,7 @@ -import { ClientOptions, Options, TracePropagationTargets } from '@sentry/types'; +import { ClientOptions, Instrumenter, Options, TracePropagationTargets } from '@sentry/types'; import { NodeTransportOptions } from './transports'; -type SentryNodeInstrumenter = 'sentry' | 'otel'; - export interface BaseNodeOptions { /** Sets an optional server name (device name) */ serverName?: string; @@ -28,7 +26,7 @@ export interface BaseNodeOptions { * * NOTE: Any option except for `sentry` is highly experimental and subject to change! */ - instrumenter?: SentryNodeInstrumenter; + instrumenter?: Instrumenter; /** Callback that is executed when a fatal global error occurs. */ onFatalError?(error: Error): void; diff --git a/packages/types/src/index.ts b/packages/types/src/index.ts index 3de84113225a..f3bc63feda4c 100644 --- a/packages/types/src/index.ts +++ b/packages/types/src/index.ts @@ -92,3 +92,4 @@ export type { } from './transport'; export type { User, UserFeedback } from './user'; export type { WrappedFunction } from './wrappedfunction'; +export type { Instrumenter } from './instrumenter'; diff --git a/packages/types/src/instrumenter.ts b/packages/types/src/instrumenter.ts new file mode 100644 index 000000000000..4212d53b11f0 --- /dev/null +++ b/packages/types/src/instrumenter.ts @@ -0,0 +1 @@ +export type Instrumenter = 'sentry' | 'otel';