From 194c9c945ca5f3e480a8fb836ed69ecb03cd8b5f Mon Sep 17 00:00:00 2001 From: Francesco Novy Date: Wed, 10 May 2023 14:00:32 +0200 Subject: [PATCH] unflake? --- .../suites/replay/throttleBreadcrumbs/subject.js | 4 ++-- .../suites/replay/throttleBreadcrumbs/test.ts | 9 +++++---- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/packages/browser-integration-tests/suites/replay/throttleBreadcrumbs/subject.js b/packages/browser-integration-tests/suites/replay/throttleBreadcrumbs/subject.js index d7ed01dd7f29..e71cc0a8bcf6 100644 --- a/packages/browser-integration-tests/suites/replay/throttleBreadcrumbs/subject.js +++ b/packages/browser-integration-tests/suites/replay/throttleBreadcrumbs/subject.js @@ -3,8 +3,8 @@ const head = document.querySelector('head'); const COUNT = 250; -window.__isLoaded = () => { - return window.loaded.length === COUNT * 2; +window.__isLoaded = (run = 1) => { + return window.loaded.length === COUNT * 2 * run; }; document.querySelector('[data-network]').addEventListener('click', () => { diff --git a/packages/browser-integration-tests/suites/replay/throttleBreadcrumbs/test.ts b/packages/browser-integration-tests/suites/replay/throttleBreadcrumbs/test.ts index 74e3a5bb7095..9fc1b0a669c8 100644 --- a/packages/browser-integration-tests/suites/replay/throttleBreadcrumbs/test.ts +++ b/packages/browser-integration-tests/suites/replay/throttleBreadcrumbs/test.ts @@ -58,7 +58,7 @@ sentryTest( }, 10_000, ); - const reqPromise1breadcrumbs = waitForReplayRequest( + const reqPromise1Breadcrumbs = waitForReplayRequest( page, (_event, res) => { const { breadcrumbs } = getCustomRecordingEvents(res); @@ -75,7 +75,7 @@ sentryTest( await forceFlushReplay(); const { performanceSpans } = getCustomRecordingEvents(await reqPromise1); - const { breadcrumbs } = getCustomRecordingEvents(await reqPromise1breadcrumbs); + const { breadcrumbs } = getCustomRecordingEvents(await reqPromise1Breadcrumbs); // All assets have been _loaded_ expect(scriptsLoaded).toBe(COUNT); @@ -101,7 +101,7 @@ sentryTest( }, 10_000, ); - const reqPromise2breadcrumbs = waitForReplayRequest( + const reqPromise2Breadcrumbs = waitForReplayRequest( page, (_event, res) => { const { breadcrumbs } = getCustomRecordingEvents(res); @@ -114,10 +114,11 @@ sentryTest( await page.click('[data-network]'); await page.click('[data-fetch]'); + await page.waitForFunction('window.__isLoaded(2)'); await forceFlushReplay(); const { performanceSpans: performanceSpans2 } = getCustomRecordingEvents(await reqPromise2); - const { breadcrumbs: breadcrumbs2 } = getCustomRecordingEvents(await reqPromise2breadcrumbs); + const { breadcrumbs: breadcrumbs2 } = getCustomRecordingEvents(await reqPromise2Breadcrumbs); // All assets have been _loaded_ expect(scriptsLoaded).toBe(COUNT * 2);