feat(core): Use path instead of debug IDs as artifact names for debug ID upload #700
+29
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@codecov-ai-reviewer review |
|
On it! We are reviewing the PR and will provide feedback shortly. |
![codecov-ai[bot]](https://avatars.githubusercontent.com/in/797565?s=60&v=4){kind=small}
lforst
changed the title
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
Mar 28, 2025
| datasource | package | from | to | | ---------- | ------------------- | ----- | ----- | | npm | @sentry/vite-plugin | 3.2.2 | 3.2.3 | ## [v3.2.3](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#323) - feat(core): Use path instead of debug IDs as artifact names for debug ID upload ([#700](getsentry/sentry-javascript-bundler-plugins#700)) - feat(webpack): Primarily use `contentHash` for debug ID hash ([#702](getsentry/sentry-javascript-bundler-plugins#702)) - feat: Detect Vercel commits and env ([#694](getsentry/sentry-javascript-bundler-plugins#694)) - feat: Default to automatically setting commits on release ([#692](getsentry/sentry-javascript-bundler-plugins#692))
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
Mar 28, 2025
| datasource | package | from | to | | ---------- | ------------------- | ----- | ----- | | npm | @sentry/vite-plugin | 3.2.2 | 3.2.3 | ## [v3.2.3](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#323) - feat(core): Use path instead of debug IDs as artifact names for debug ID upload ([#700](getsentry/sentry-javascript-bundler-plugins#700)) - feat(webpack): Primarily use `contentHash` for debug ID hash ([#702](getsentry/sentry-javascript-bundler-plugins#702)) - feat: Detect Vercel commits and env ([#694](getsentry/sentry-javascript-bundler-plugins#694)) - feat: Default to automatically setting commits on release ([#692](getsentry/sentry-javascript-bundler-plugins#692))
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
Mar 29, 2025
| datasource | package | from | to | | ---------- | ------------------- | ----- | ----- | | npm | @sentry/vite-plugin | 3.2.2 | 3.2.4 | ## [v3.2.4](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#324) - Revert "feat(core): Use path instead of debug IDs as artifact names for debug ID upload ([#700](getsentry/sentry-javascript-bundler-plugins#700))" ([#709](getsentry/sentry-javascript-bundler-plugins#709)) - ref: Remove deprecated use of `useArtifacBundles` ([#707](getsentry/sentry-javascript-bundler-plugins#707)) ## [v3.2.3](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#323) - feat(core): Use path instead of debug IDs as artifact names for debug ID upload ([#700](getsentry/sentry-javascript-bundler-plugins#700)) - feat(webpack): Primarily use `contentHash` for debug ID hash ([#702](getsentry/sentry-javascript-bundler-plugins#702)) - feat: Detect Vercel commits and env ([#694](getsentry/sentry-javascript-bundler-plugins#694)) - feat: Default to automatically setting commits on release ([#692](getsentry/sentry-javascript-bundler-plugins#692))
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
Mar 30, 2025
| datasource | package | from | to | | ---------- | ------------------- | ----- | ----- | | npm | @sentry/vite-plugin | 3.2.2 | 3.2.4 | ## [v3.2.4](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#324) - Revert "feat(core): Use path instead of debug IDs as artifact names for debug ID upload ([#700](getsentry/sentry-javascript-bundler-plugins#700))" ([#709](getsentry/sentry-javascript-bundler-plugins#709)) - ref: Remove deprecated use of `useArtifacBundles` ([#707](getsentry/sentry-javascript-bundler-plugins#707)) ## [v3.2.3](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#323) - feat(core): Use path instead of debug IDs as artifact names for debug ID upload ([#700](getsentry/sentry-javascript-bundler-plugins#700)) - feat(webpack): Primarily use `contentHash` for debug ID hash ([#702](getsentry/sentry-javascript-bundler-plugins#702)) - feat: Detect Vercel commits and env ([#694](getsentry/sentry-javascript-bundler-plugins#694)) - feat: Default to automatically setting commits on release ([#692](getsentry/sentry-javascript-bundler-plugins#692))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes our "upload preparation" logic in the debug ID upload to not emit files named after their debug IDs, but rather after their actual file-names.
Files that would have previously been uploaded as
~/0-96b0eb2b-013a-5640-8ffc-4fd8465bb570.jswould now be uploaded as~/0/out/rollup/entrypoint1.mjswhich is slightly easier to debug.We still need to do some kind of collision-prevention in case two files are named identically relative to cwd after normalization, so that's why there's still a
/{number}prefix in the artifact name (it is the "bundle index" which is an incrementing counter).