Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to disable dedupe filter in spring boot #3426

Closed
piotrblasiak opened this issue May 16, 2024 · 6 comments
Closed

Make it possible to disable dedupe filter in spring boot #3426

piotrblasiak opened this issue May 16, 2024 · 6 comments

Comments

@piotrblasiak
Copy link

Problem Statement

Currently it is impossible to disable the deduplication filter when using the spring boot starter.

Solution Brainstorm

No response

@adinauer
Copy link
Member

Hello @piotrblasiak, can you please elaborate on why you'd like to disable the filter? Is it filtering too much? There'll likely be a lot more events being sent to Sentry, consuming your quota.

@piotrblasiak
Copy link
Author

I'm actually surprised the filter is enabled by default - I want to be able to see how often some errors occur. Some one-time errors may not be super serious, but some may affect a lot of users and should be dealt with as soon as possible. Is this not a very common way to reason about error reporting?

@adinauer
Copy link
Member

Hmm maybe there's a misunderstanding here, the filter shouldn't filter out a similar error happening again but instead is meant to filter out actual duplicates, e.g. when a logging integration as well as an exception handler try to capture the same exception twice.

@piotrblasiak
Copy link
Author

Well, if the exact same exception happens for different users, I want to know about that - also even if it's for the same user but at different times it is valuable to know, no? Why else would your dashboard show how many times an error has happened?

@adinauer
Copy link
Member

adinauer commented May 16, 2024

It'd have to be the exact same Throwable reference (i.e. ==) being captured again for it to be filtered out by DuplicateEventDetectionEventProcessor, so in the case you're describing it should NOT filter it out. Did you run into problems when playing around or is this a theoretical concern?

@piotrblasiak
Copy link
Author

Aha ok, I thought I had read it compared the stack traces and not the object references. If that's the case, I guess all is fine. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Archived in project
Development

No branches or pull requests

2 participants