New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Replay Item types #2441
Add Replay Item types #2441
Conversation
Nice one 👍 I think you need to run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Oh I didn't know, will run it right now! |
Codecov ReportBase: 80.09% // Head: 80.09% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2441 +/- ##
=========================================
Coverage 80.09% 80.09%
Complexity 3807 3807
=========================================
Files 306 306
Lines 14390 14392 +2
Branches 1904 1904
=========================================
+ Hits 11525 11527 +2
Misses 2118 2118
Partials 747 747
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Lukas
📜 Description
This PR adds the missing Event types for Replay to work with Hybrid SDK. (replay_event and replay_recording)
💡 Motivation and Context
Replay is broken when sending using Android because the item header keeps getting replaced by "unknown"
💚 How did you test it?
following the contributing documentation of Capacitor.
deploying a local SDK and testing it with Sentry Capacitor, generating the following error/replay:
https://sentry.io/organizations/sentry-sdks/replays/sentry-capacitor:201ffafe1cc34c92bdf5ea467e6ab442/?referrer=%2Forganizations%2F%3AorgId%2Fdiscover%2F%3AeventSlug%2F&t=5&t_main=console
📝 Checklist
🔮 Next steps
#skip-changelog (I don't think this is needed to be included on the changelog from the Android SDK since it has no impact for now on the Native SDK)