Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Replay Item types #2441

Merged
merged 7 commits into from Dec 29, 2022
Merged

Conversation

lucas-zimerman
Copy link
Contributor

@lucas-zimerman lucas-zimerman commented Dec 23, 2022

📜 Description

This PR adds the missing Event types for Replay to work with Hybrid SDK. (replay_event and replay_recording)

💡 Motivation and Context

Replay is broken when sending using Android because the item header keeps getting replaced by "unknown"

💚 How did you test it?

following the contributing documentation of Capacitor.
deploying a local SDK and testing it with Sentry Capacitor, generating the following error/replay:
https://sentry.io/organizations/sentry-sdks/replays/sentry-capacitor:201ffafe1cc34c92bdf5ea467e6ab442/?referrer=%2Forganizations%2F%3AorgId%2Fdiscover%2F%3AeventSlug%2F&t=5&t_main=console

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

🔮 Next steps

#skip-changelog (I don't think this is needed to be included on the changelog from the Android SDK since it has no impact for now on the Native SDK)

@lucas-zimerman lucas-zimerman marked this pull request as ready for review December 26, 2022 10:01
@markushi
Copy link
Member

Nice one 👍 I think you need to run ./gradlew apiDump on the project root folder to update the .api files, this should make the tests green.

Copy link
Member

@adinauer adinauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lucas-zimerman
Copy link
Contributor Author

Nice one 👍 I think you need to run ./gradlew apiDump on the project root folder to update the .api files, this should make the tests green.

Oh I didn't know, will run it right now!

@codecov-commenter
Copy link

codecov-commenter commented Dec 28, 2022

Codecov Report

Base: 80.09% // Head: 80.09% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (f974534) compared to base (b3704c8).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2441   +/-   ##
=========================================
  Coverage     80.09%   80.09%           
  Complexity     3807     3807           
=========================================
  Files           306      306           
  Lines         14390    14392    +2     
  Branches       1904     1904           
=========================================
+ Hits          11525    11527    +2     
  Misses         2118     2118           
  Partials        747      747           
Impacted Files Coverage Δ
sentry/src/main/java/io/sentry/SentryItemType.java 87.50% <100.00%> (+0.83%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lucas-zimerman lucas-zimerman requested review from adinauer and removed request for markushi, romtsn and stefanosiano December 28, 2022 12:21
Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Lukas

@romtsn romtsn merged commit 95647bd into getsentry:main Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants