Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix craft not handling multidigit version numbers #2433

Merged
merged 1 commit into from Dec 16, 2022
Merged

Fix craft not handling multidigit version numbers #2433

merged 1 commit into from Dec 16, 2022

Conversation

romtsn
Copy link
Member

@romtsn romtsn commented Dec 16, 2022

#skip-changelog

@romtsn romtsn enabled auto-merge (squash) December 16, 2022 11:20
adinauer
adinauer approved these changes Dec 16, 2022
View reviewed changes
Copy link
Member

@adinauer adinauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@romtsn romtsn merged commit c5366ae into main Dec 16, 2022
@romtsn romtsn deleted the fix/craft-multidigits-version branch December 16, 2022 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adinauer adinauer adinauer approved these changes

@stefanosiano stefanosiano Awaiting requested review from stefanosiano stefanosiano is a code owner

@markushi markushi Awaiting requested review from markushi markushi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@romtsn @adinauer