Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert sourcesets config to produce same modules as before #2431

Merged
merged 1 commit into from Dec 16, 2022

Conversation

markushi
Copy link
Member

@markushi markushi commented Dec 15, 2022

📜 Description

This will produce artifacts for sentry-compose, sentry-compose-android, sentry-compose-desktop

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

🔮 Next steps

#skip-changelog

this will produce artifacts for sentry-compose, sentry-compose-android,
sentry-compose-desktop
@markushi markushi changed the title Reverts sourcesets config to produce same modules as before Revert sourcesets config to produce same modules as before Dec 15, 2022
@codecov-commenter
Copy link

Codecov Report

Base: 80.05% // Head: 80.05% // No change to project coverage 👍

Coverage data is based on head (ce750fe) compared to base (606823f).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2431   +/-   ##
=========================================
  Coverage     80.05%   80.05%           
  Complexity     3799     3799           
=========================================
  Files           306      306           
  Lines         14312    14312           
  Branches       1903     1903           
=========================================
  Hits          11457    11457           
  Misses         2110     2110           
  Partials        745      745           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kahest kahest self-requested a review December 15, 2022 20:04
val jvmMain by getting {
dependencies {
api(projects.sentry)
implementation(Config.Libs.kotlinStdLib)
api(projects.sentryComposeHelper)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm, I'm a bit surprised it's gonna work, because it contains only java files and we include it into kotlin-common-main. My idea was to just publish another artifact (-jvm.jar), but if this works, then it's good I guess :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just double checked the artifacts when publishing locally:

  • sentry-compose.jar is empty like before
  • sentry-compose-android.jar and sentry-compose-desktop.jar both contain the relevant class files, including the ones from sentry-helper

I'm still not happy with this solutions, as it feels like too many workarounds stacked on each other - but I would release it for now and check on how this can be improved in the next iteration.

@romtsn romtsn merged commit 063f12a into main Dec 16, 2022
@romtsn romtsn deleted the fix/sentry-compose-module-publish branch December 16, 2022 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants