Fix ensure all options are processed before integrations are loaded

[markushi]

📜 Description

Right now some integrations are created between default/auto-init and the custom SentryOptions.configure callback. If an integration copies references from SentryOptions it can hold a stale configuration, as the SentryOptions.configure block can change any option afterwards.

This is a quick fix, I guess in the long run we should take a look into streamlining the overall SDK init process to avoid these kind of issues.

This PR splits up the AndroidOptionsInitializer.init method into two parts:

• loadDefaultAndMetadataOptions()
• initializeIntegrationsAndProcessors()

This allows us to execute execute the custom OptionsConfiguration.configure() callback in-between, which ensures all options are set before any integrations and processors are created.

💡 Motivation and Context

Fixes #2373

💚 How did you test it?

📝 Checklist

• I reviewed the submitted code
• I added tests to verify the changes
• I updated the docs if needed
• No breaking changes

🔮 Next steps

[github-actions]

Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	286.00 ms	295.13 ms	9.13 ms
Size	1.73 MiB	2.33 MiB	612.69 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
f809aac	301.51 ms	346.60 ms	45.09 ms
a04f788	321.78 ms	354.12 ms	32.35 ms
38e4f11	358.20 ms	433.73 ms	75.53 ms
507f924	342.51 ms	402.65 ms	60.14 ms
90e9745	314.68 ms	357.28 ms	42.60 ms
7597ded	289.60 ms	339.69 ms	50.09 ms

App size

Revision	Plain	With Sentry	Diff
f809aac	1.73 MiB	2.32 MiB	608.63 KiB
a04f788	1.73 MiB	2.32 MiB	609.88 KiB
38e4f11	1.73 MiB	2.32 MiB	609.82 KiB
507f924	1.73 MiB	2.32 MiB	609.95 KiB
90e9745	1.73 MiB	2.32 MiB	608.63 KiB
7597ded	1.73 MiB	2.32 MiB	609.88 KiB

Previous results on branch: fix/sentry-init-cache-folder

Startup times

Revision	Plain	With Sentry	Diff
629a327	339.80 ms	385.59 ms	45.79 ms
42efe66	384.22 ms	440.48 ms	56.26 ms
8b13643	341.57 ms	396.72 ms	55.15 ms
423b573	305.68 ms	354.96 ms	49.28 ms
aba9a75	317.06 ms	367.67 ms	50.61 ms
fbefdb1	333.34 ms	369.27 ms	35.93 ms

App size

Revision	Plain	With Sentry	Diff
629a327	1.73 MiB	2.32 MiB	609.99 KiB
42efe66	1.73 MiB	2.32 MiB	609.99 KiB
8b13643	1.73 MiB	2.32 MiB	609.99 KiB
423b573	1.73 MiB	2.33 MiB	612.79 KiB
aba9a75	1.73 MiB	2.32 MiB	609.99 KiB
fbefdb1	1.73 MiB	2.32 MiB	609.99 KiB

[codecov-commenter]

Codecov Report

Base: 80.28% // Head: 80.28% // No change to project coverage 👍

Coverage data is based on head (16ca514) compared to base (ed00ecb).
Patch has no changes to coverable lines.

Additional details and impacted files

@@            Coverage Diff            @@
##               main    #2377   +/-   ##
=========================================
  Coverage     80.28%   80.28%           
  Complexity     3690     3690           
=========================================
  Files           292      292           
  Lines         13845    13845           
  Branches       1833     1833           
=========================================
  Hits          11116    11116           
  Misses         2014     2014           
  Partials        715      715           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[romtsn]

LGTM, but two points:

• Can we add a test that tests specifically this problem (manually init and check that the cacheDir of EnvelopeCache is the correct one with the dsn hash in the path)?
• Can we switch to manual init in the sample app with this PR as well pls? thanks