Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update profiling release field #2371

Merged
merged 5 commits into from Dec 2, 2022
Merged

Conversation

stefanosiano
Copy link
Member

@stefanosiano stefanosiano commented Nov 16, 2022

📜 Description

put the release in the profiling payload
#skip-changelog

💡 Motivation and Context

We were previously using the version name and version code. We moved to using the release to be aligned with the other events

💚 How did you test it?

Unit test

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

🔮 Next steps

- replaced versionCode with an empty string
- replaced versionName with release string
@stefanosiano stefanosiano marked this pull request as ready for review November 16, 2022 18:52
@github-actions
Copy link
Contributor

github-actions bot commented Nov 16, 2022

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 365.35 ms 413.86 ms 48.51 ms
Size 1.73 MiB 2.32 MiB 612.39 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
f809aac 301.51 ms 346.60 ms 45.09 ms
81a1a6c 328.73 ms 421.28 ms 92.55 ms
4a9c176 319.77 ms 363.20 ms 43.43 ms
3695453 299.25 ms 360.04 ms 60.79 ms
7967d22 289.28 ms 377.11 ms 87.83 ms
507f924 342.51 ms 402.65 ms 60.14 ms
4a9c176 336.33 ms 384.73 ms 48.41 ms
3695453 314.63 ms 353.10 ms 38.47 ms
38e4f11 358.20 ms 433.73 ms 75.53 ms
16371c5 314.02 ms 394.54 ms 80.52 ms

App size

Revision Plain With Sentry Diff
f809aac 1.73 MiB 2.32 MiB 608.63 KiB
81a1a6c 1.73 MiB 2.32 MiB 612.47 KiB
4a9c176 1.73 MiB 2.33 MiB 612.69 KiB
3695453 1.73 MiB 2.32 MiB 611.62 KiB
7967d22 1.73 MiB 2.32 MiB 612.47 KiB
507f924 1.73 MiB 2.32 MiB 609.95 KiB
4a9c176 1.73 MiB 2.33 MiB 612.69 KiB
3695453 1.73 MiB 2.32 MiB 611.62 KiB
38e4f11 1.73 MiB 2.32 MiB 609.82 KiB
16371c5 1.73 MiB 2.32 MiB 611.62 KiB

Previous results on branch: update/profiling-release-field

Startup times

Revision Plain With Sentry Diff
ec6974c 362.68 ms 396.48 ms 33.80 ms

App size

Revision Plain With Sentry Diff
ec6974c 1.73 MiB 2.32 MiB 609.86 KiB

@codecov-commenter
Copy link

Codecov Report

Base: 80.03% // Head: 80.03% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (b631b17) compared to base (31f3e4c).
Patch coverage: 75.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2371   +/-   ##
=========================================
  Coverage     80.03%   80.03%           
+ Complexity     3767     3765    -2     
=========================================
  Files           301      301           
  Lines         14210    14207    -3     
  Branches       1885     1884    -1     
=========================================
- Hits          11373    11371    -2     
  Misses         2092     2092           
+ Partials        745      744    -1     
Impacted Files Coverage Δ
...ry/src/main/java/io/sentry/ProfilingTraceData.java 78.51% <75.00%> (+0.14%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@stefanosiano stefanosiano merged commit 34a8bfd into main Dec 2, 2022
@stefanosiano stefanosiano deleted the update/profiling-release-field branch December 2, 2022 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants