New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update profiling release field #2371
Conversation
- replaced versionCode with an empty string - replaced versionName with release string
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
f809aac | 301.51 ms | 346.60 ms | 45.09 ms |
81a1a6c | 328.73 ms | 421.28 ms | 92.55 ms |
4a9c176 | 319.77 ms | 363.20 ms | 43.43 ms |
3695453 | 299.25 ms | 360.04 ms | 60.79 ms |
7967d22 | 289.28 ms | 377.11 ms | 87.83 ms |
507f924 | 342.51 ms | 402.65 ms | 60.14 ms |
4a9c176 | 336.33 ms | 384.73 ms | 48.41 ms |
3695453 | 314.63 ms | 353.10 ms | 38.47 ms |
38e4f11 | 358.20 ms | 433.73 ms | 75.53 ms |
16371c5 | 314.02 ms | 394.54 ms | 80.52 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
f809aac | 1.73 MiB | 2.32 MiB | 608.63 KiB |
81a1a6c | 1.73 MiB | 2.32 MiB | 612.47 KiB |
4a9c176 | 1.73 MiB | 2.33 MiB | 612.69 KiB |
3695453 | 1.73 MiB | 2.32 MiB | 611.62 KiB |
7967d22 | 1.73 MiB | 2.32 MiB | 612.47 KiB |
507f924 | 1.73 MiB | 2.32 MiB | 609.95 KiB |
4a9c176 | 1.73 MiB | 2.33 MiB | 612.69 KiB |
3695453 | 1.73 MiB | 2.32 MiB | 611.62 KiB |
38e4f11 | 1.73 MiB | 2.32 MiB | 609.82 KiB |
16371c5 | 1.73 MiB | 2.32 MiB | 611.62 KiB |
…TraceData for better backward compatibility
Codecov ReportBase: 80.03% // Head: 80.03% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2371 +/- ##
=========================================
Coverage 80.03% 80.03%
+ Complexity 3767 3765 -2
=========================================
Files 301 301
Lines 14210 14207 -3
Branches 1885 1884 -1
=========================================
- Hits 11373 11371 -2
Misses 2092 2092
+ Partials 745 744 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
📜 Description
put the release in the profiling payload
#skip-changelog
💡 Motivation and Context
We were previously using the version name and version code. We moved to using the release to be aligned with the other events
💚 How did you test it?
Unit test
📝 Checklist
🔮 Next steps