Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated ui test dependencies and benchmark device #2353

Merged
merged 1 commit into from Nov 11, 2022

Conversation

stefanosiano
Copy link
Member

📜 Description

updated ui test dependencies for Android 13
updated benchmark device
#skip-changelog

💡 Motivation and Context

Ui test dependencies have been updated to work better on Android 13 (ui interactions through espresso was not working)
A device on Saucelabs is giving an error for a "Don't keep activities" developer option, which we have no control over. So we are changing it with another device with similar spec (Google Pixel 2 -> Oneplus Nord N200)

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

🔮 Next steps

@stefanosiano stefanosiano marked this pull request as ready for review November 11, 2022 11:53
@codecov-commenter
Copy link

Codecov Report

Base: 80.36% // Head: 80.36% // No change to project coverage 👍

Coverage data is based on head (122b3f9) compared to base (3ac76b6).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2353   +/-   ##
=========================================
  Coverage     80.36%   80.36%           
  Complexity     3670     3670           
=========================================
  Files           290      290           
  Lines         13712    13712           
  Branches       1801     1801           
=========================================
  Hits          11020    11020           
  Misses         2001     2001           
  Partials        691      691           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@stefanosiano stefanosiano merged commit fb3fab7 into main Nov 11, 2022
@stefanosiano stefanosiano deleted the fix/benchmark-device-update branch November 11, 2022 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants