Add the name of the exception to the beforeSend callback failed breadcrumb.

[adinauer]

Problem Statement

A failed beforeSend callback adds a breadcrumb that only contains the message of the exception.

sentry-java/sentry/src/main/java/io/sentry/SentryClient.java

Lines 664 to 681 in d4087ee

	} catch (Throwable e) {
	options
	.getLogger()
	.log(
	SentryLevel.ERROR,
	"The BeforeSend callback threw an exception. It will be added as breadcrumb and continue.",
	e);
	final Breadcrumb breadcrumb = new Breadcrumb();
	breadcrumb.setMessage("BeforeSend callback failed.");
	breadcrumb.setCategory("SentryClient");
	breadcrumb.setLevel(SentryLevel.ERROR);
	if (e.getMessage() != null) {
	breadcrumb.setData("sentry:message", e.getMessage());
	}
	event.addBreadcrumb(breadcrumb);
	}

Solution Brainstorm

It would also be helpful if the type of the exception was visible on the Sentry UI as sometimes only the combination of the two tells you the full story.

[romtsn]

The type of the exception only makes sense if the app is not obfuscated (because we do not de-obfuscate breadcrumbs at the moment), or if it's the exception from JDK.

Let's put this item on the TSC and also check what other SDKs are doing in this case. @adinauer will take care of it.

[adinauer]

We decided not to add more details to the breadcrumb but instead no longer send event / transaction in case beforeSend / beforeSendTransaction throws. More details can be found in #2591