Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Timber tags #1900

Closed
romtsn opened this issue Feb 8, 2022 · 3 comments · Fixed by #1974
Closed

Support Timber tags #1900

romtsn opened this issue Feb 8, 2022 · 3 comments · Fixed by #1974
Labels

Comments

@romtsn
Copy link
Member

romtsn commented Feb 8, 2022

We have no way to get the tag when inheriting Timber.Tree, because it's marked as internal/package-private for consumers https://github.com/JakeWharton/timber/blob/dc45d69b081a03e3fb83e81a7aee0f430f46b4f1/timber/src/main/java/timber/log/Timber.kt#L22. This means, when timber is used like this:

Timber.tag("Tag")
Timber.e("Issue")

the tag will not be reflected on Sentry.

If this gets traction, we could either offer a reflection-based support or automatically infer classname of the caller (that's what Timber.DebugTree does by default).

Please, vote on this issue if you'd like us to provide support for Timber tags.

@bruno-garcia
Copy link
Member

Would they accept a PR upstream that adds an API to get the tags?

@romtsn
Copy link
Member Author

romtsn commented Feb 9, 2022

There is actually a few open PRs addressing that (this is the closest one to what we want https://github.com/JakeWharton/timber/pull/224/files), but none of them get any traction unfortunately.

@marandaneto
Copy link
Contributor

Would they accept a PR upstream that adds an API to get the tags?

We can try but JakeWharton/timber#393 never got a reply/review.

@audkar audkar mentioned this issue Apr 5, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants