Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add locale to device context and deprecate language #1832

Merged
merged 6 commits into from Dec 9, 2021

Conversation

marandaneto
Copy link
Contributor

@marandaneto marandaneto commented Dec 9, 2021

馃摐 Description

Feat: Add locale to device context and deprecate language
language now returns only the language eg en instead of en_US, since the language field was never indexed, its not a breaking change on discover and alerts

馃挕 Motivation and Context

language was actually the locale, and locale was missing.
Closes #1834

馃挌 How did you test it?

unit tests

馃摑 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

馃敭 Next steps

add Support for https://develop.sentry.dev/sdk/event-payloads/contexts/#culture-context

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment.

@codecov-commenter
Copy link

codecov-commenter commented Dec 9, 2021

Codecov Report

Merging #1832 (3afbd41) into main (5ce8406) will decrease coverage by 0.02%.
The diff coverage is 25.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1832      +/-   ##
============================================
- Coverage     75.72%   75.69%   -0.03%     
  Complexity     2194     2194              
============================================
  Files           218      218              
  Lines          7806     7810       +4     
  Branches        828      828              
============================================
+ Hits           5911     5912       +1     
- Misses         1493     1496       +3     
  Partials        402      402              
Impacted Files Coverage 螖
...entry/src/main/java/io/sentry/protocol/Device.java 97.08% <25.00%> (-2.17%) 猬囷笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 5ce8406...3afbd41. Read the comment docs.

@marandaneto marandaneto mentioned this pull request Dec 9, 2021
1 task
@marandaneto marandaneto merged commit b182c6e into main Dec 9, 2021
@marandaneto marandaneto deleted the ref/add-locale branch December 9, 2021 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Device Context Locale to 5.x
4 participants