Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Do not start fragment span if not added to the Activity #1813

Merged
merged 2 commits into from Nov 18, 2021
Merged

Fix: Do not start fragment span if not added to the Activity #1813

merged 2 commits into from Nov 18, 2021

Conversation

marandaneto
Copy link
Contributor

@marandaneto marandaneto commented Nov 18, 2021 •
edited

馃摐 Description

Fix: Do not start fragment span if not added to the Activity

馃挕 Motivation and Context

Closes #1787

馃挌 How did you test it?

running https://github.com/LouisFn/SentryFrozenFrame and repo's sample with added/visible fragments

馃摑 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

馃敭 Next steps

@marandaneto marandaneto changed the title changelog Fix: Do not start fragment span if not added to the Activity Nov 18, 2021
@marandaneto marandaneto mentioned this pull request Nov 18, 2021
Closed
4 tasks
@marandaneto marandaneto merged commit 6a82066 into main Nov 18, 2021
@marandaneto marandaneto deleted the fix/fragment-not-added branch November 18, 2021 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romtsn romtsn romtsn approved these changes

@maciejwalkowiak maciejwalkowiak Awaiting requested review from maciejwalkowiak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Odd activity auto tracing duration
2 participants
@marandaneto @romtsn