Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor OkHttp and Apollo to Kotlin functional interfaces. #1797

Merged
merged 4 commits into from Nov 12, 2021

Conversation

maciejwalkowiak
Copy link
Contributor

@maciejwalkowiak maciejwalkowiak commented Nov 8, 2021

馃摐 Description

Refactor OkHttp and Apollo to Kotlin functional interfaces.

馃挕 Motivation and Context

Reduces boilerplate when using callbacks in Kotlin code.

馃挌 How did you test it?

Already covered with unit tests.

馃摑 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

@maciejwalkowiak maciejwalkowiak marked this pull request as ready for review November 8, 2021 05:22
@codecov-commenter
Copy link

codecov-commenter commented Nov 8, 2021

Codecov Report

Merging #1797 (c72cddd) into main (eebe56a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #1797   +/-   ##
=========================================
  Coverage     75.74%   75.74%           
  Complexity     2194     2194           
=========================================
  Files           218      218           
  Lines          7804     7804           
  Branches        828      828           
=========================================
  Hits           5911     5911           
  Misses         1491     1491           
  Partials        402      402           
Impacted Files Coverage 螖
...n/java/io/sentry/apollo/SentryApolloInterceptor.kt 78.94% <酶> (酶)

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update eebe56a...c72cddd. Read the comment docs.

@marandaneto
Copy link
Contributor

That sounds like a nice refactoring, is it a breaking change in Java or Kotlin? or IDE would just point out to simplify the code?

Copy link
Contributor

@marandaneto marandaneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's a comment to be answered otherwise LGTM, thanks!

@maciejwalkowiak
Copy link
Contributor Author

Tested - non breaking for both Java and Kotlin

@marandaneto marandaneto merged commit 5ba7d38 into main Nov 12, 2021
@marandaneto marandaneto deleted the kotlin-sam branch November 12, 2021 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants