Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make lifecycle breadcrumbs logged by sentry-android-fragment integration customizable #1734

Closed
mateuszkwiecinski opened this issue Sep 22, 2021 · 2 comments

Comments

@mateuszkwiecinski
Copy link

Context

I tried to add FragmentLifecycleIntegration to my app, and I quickly reached default breadcrumbs limit. Almost all events came from FragmentLifecycleIntegration which decreased number of visible user interactions to last 2-3 screens before crash.
I could increase breadcrumbs limit, but I concluded I'd prefer see less events logged by FragmentLifecycleIntegration.

Proposal

The simples thing I can suggest is to introduce api like:

FragmentLifecycleIntegration(
	application = application,
	loggedLifecycleEvents = setOf(Lifecycle.State.RESUMED, Lifecycle.State.PAUSED),
)

which would skip events non-listed in new parameter.

@marandaneto
Copy link
Contributor

@mateuszkwiecinski thanks for reporting, such grain fined level makes sense, let's see if people upvote.

a workaround, for now, is using the BeforeBreadcrumb callback to filter breadcrumbs out https://docs.sentry.io/platforms/android/enriching-events/breadcrumbs/#customize-breadcrumbs
or obviously, increasing the number of crumbs.

@romtsn
Copy link
Member

romtsn commented Oct 31, 2022

Closed by #2299

@romtsn romtsn closed this as completed Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

3 participants