Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: Update .craft.yml to be ready for otel submodule release #565

Merged
merged 1 commit into from Feb 2, 2023

Conversation

tonyo
Copy link
Member

@tonyo tonyo commented Feb 2, 2023

Craft v0.35.0 supports tagOnly attribute for github target, so we can already prepare for the next release, where the new submodule (otel) becomes the part of the repo.

For now we agreed to have version parity between the root SDK and all submodules, for simplicity.

@codecov
Copy link

codecov bot commented Feb 2, 2023

Codecov Report

Base: 74.71% // Head: 74.71% // No change to project coverage 👍

Coverage data is based on head (b5b81ed) compared to base (beca7e6).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #565   +/-   ##
=======================================
  Coverage   74.71%   74.71%           
=======================================
  Files          38       38           
  Lines        3837     3837           
=======================================
  Hits         2867     2867           
  Misses        850      850           
  Partials      120      120           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tonyo tonyo merged commit fb76180 into master Feb 2, 2023
@tonyo tonyo deleted the tonyo/update-craft-submodule branch February 2, 2023 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants