Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref: Rename ClientOptions.SendDefaultPii to ClientOptions.SendDefaultPII #490

Merged
merged 1 commit into from Nov 2, 2022
Merged

ref: Rename ClientOptions.SendDefaultPii to ClientOptions.SendDefaultPII #490

merged 1 commit into from Nov 2, 2022

Conversation

cleptric
Copy link
Member

@cleptric cleptric commented Nov 2, 2022

@cleptric cleptric added this to the v0.15.0 milestone Nov 2, 2022
@cleptric cleptric self-assigned this Nov 2, 2022
@cleptric cleptric mentioned this pull request Nov 2, 2022
Merged
AbhiPrasad
AbhiPrasad reviewed Nov 2, 2022
View reviewed changes
Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand this helps unify with the Go ecosystem - but in this case we use the lowercase version of SendDefaultPii in every single other SDK, I'd rather stay consistent with the rest of the SDK

@cleptric
Copy link
Member Author

cleptric commented Nov 2, 2022

I think it's ok to stay unified with the Go ecosystem, especially if we expand on better linting in the future.
In terms of DevEx, IDEs should autocomplete on this just fine.

AbhiPrasad
AbhiPrasad approved these changes Nov 2, 2022
View reviewed changes
Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll have to update the docs about this as well then!

@cleptric
Copy link
Member Author

cleptric commented Nov 2, 2022

Yes Sir! getsentry/sentry-docs#5708

@cleptric cleptric merged commit 19c8481 into master Nov 2, 2022
@cleptric cleptric deleted the rename-pii branch November 2, 2022 11:01
@cleptric cleptric mentioned this pull request Nov 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

Assignees

@cleptric cleptric

Labels
Type: Improvement
Projects
None yet
Milestone
v0.15.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cleptric @AbhiPrasad