Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version v0.14.0 released with breaking change. #479

Closed
adrianosela opened this issue Oct 5, 2022 · 1 comment
Closed

Version v0.14.0 released with breaking change. #479

adrianosela opened this issue Oct 5, 2022 · 1 comment

Comments

@adrianosela
Copy link

adrianosela commented Oct 5, 2022

Notes:

Not sure of a better way to communicate this than a github issue. You may want to be aware that v0.14.0 (minor update) was released with a breaking change - introduced in:

Folks already defining the Contexts field of the Event object as a map[string]interface{} will get build-time errors:

cannot use make(map[string]interface{}) (value of type map[string]interface{}) as type map[string]map[string]interface{} in struct literal
@kamilogorek
Copy link
Contributor

Hey, thanks for filling out the issue. As we are still in pre-v1 release, we are still ironing out the API and concrete types for the SDK.
As per SemVer, we are allowed to do that without bumping a major release - https://semver.org/#spec-item-4
We already did that multiple times in the past, however this time, I completely forgot about this change, as it's been 5mo since I merged it 😅

The change is legitimate, as context payload for the event can only accept nested map, where key has to be a string.
So in theory map[string]interface{} can cover that, but it's also too generic, as map[string]map[string]interface{} is the only allowed type by our processing servers.

Updated changelog and release notes to include that information: #480

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants