Make maximum amount of spans configurable #460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think exists config on server too and user can not change config on server |
|
I have tested on one of our self hosted instances. Works fine with a higher limit (as far as I can check without any settings on Server side). |
|
@fsrv-xyz Can you add some tests for this so we get it merged? |
|
@cleptric Sure. I added some test cases covering the added code (and some additional things). |
cleptric
reviewed
Nov 1, 2022
Co-authored-by: Michi Hoffmann <cleptric@users.noreply.github.com>
Co-authored-by: Michi Hoffmann <cleptric@users.noreply.github.com>
Co-authored-by: Michi Hoffmann <cleptric@users.noreply.github.com>
|
I applied the changes you suggested and updated the changelog file. |
cleptric
approved these changes
Nov 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In one of my projects, I need to do performance monitoring for complex tasks with the highest possible accuracy.
Due to some of the tasks are long running, the current
constspan limit of 1000 per transaction will be not enough.I saw, that some other SDKs (for example python) have an option for that.