Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated ioutil pkg with os & io #454

Closed
wants to merge 1 commit into from

Conversation

abhinavnair
Copy link
Contributor

As of Go 1.16, the same functionality is now provided by package io or
package os, and those implementations should be preferred in new code.

So replacing all usage of ioutil pkg with io & os.

As of Go 1.16, the same functionality is now provided by package io or
package os, and those implementations should be preferred in new code.

So replacing all usage of ioutil pkg with io & os.
@YaroslavPodorvanov
Copy link
Contributor

@kamilogorek this PR safe

Copy link
Member

@cleptric cleptric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abhinavnair Would you be so kind as to update the Changelog.md and include a note similar to https://github.com/getsentry/sentry-go/blob/master/CHANGELOG.md#v0120 letting folks know that versions before 1.16 won't work anymore?

@kamilogorek
Copy link
Contributor

LGTM. @cleptric we will update support note once #470 is merged, just prior to releasing next version.

@kamilogorek
Copy link
Contributor

It looks like something got stuck in GH actions. @abhinavnair can you push an empty commit to retrigger checks? git commit --allow-empty --allow-empty-message -m ""

@smeubank
Copy link
Member

smeubank commented Sep 6, 2022

i was just looped in here, and possibly I am being a bit overcautious 😅 . And I'm no expert in Go, we just see some significant number of events coming in for sub 1.16 Go versions. So I am wondering if this breaking change can be based on some version dependency check from the SDK?

@smeubank
Copy link
Member

any thoughts on my post above? @kamilogorek maybe we just need to make a decision here on what to do

@vladanpaunovic
Copy link
Contributor

Together with @smeubank , we'll follow up on this, respecting our depreciation policy.

auto-merge was automatically disabled October 4, 2022 16:09

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants